Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap call to 'predict' with usage_collector #548

Merged
merged 36 commits into from
Aug 22, 2024

Conversation

grzegorz-roboflow
Copy link
Contributor

Description

Enable collecting usage when calling predict

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

CI tests

Any specific deployment considerations

N/A

Docs

N/A

except Exception as exc:
logger.debug("Unable to create instance of SQLiteQueue, %s", exc)
logger.debug("No persistence")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we fallbacking into memory queue here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, hence no persistence

@@ -118,10 +118,12 @@ def empty(self, connection: Optional[sqlite3.Connection] = None) -> bool:

return rows_count == 0

def _flush_db(self, connection: sqlite3.Connection) -> List[Dict[str, Any]]:
def _flush_db(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grzegorz-roboflow grzegorz-roboflow force-pushed the cover-model-usage-in-usage-collector branch from d415ba2 to 97159cf Compare August 21, 2024 11:31
@grzegorz-roboflow grzegorz-roboflow merged commit 3c0200f into main Aug 22, 2024
58 checks passed
@grzegorz-roboflow grzegorz-roboflow deleted the cover-model-usage-in-usage-collector branch August 22, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants