handle grffile as a legacy package in template.tex

[cderv]

This will close #7 and relates to rstudio/rmarkdown#1691

There was a change with grffile tex package that is now a legacy package and no more on Texlive.
The template calls explicitly this 📦 and creates some errors.

This PR just uses the same fix as in Rmarkdown.

I should help fix it

[jrennstich]

Not working on my end unfortunately :-( Installed the new version, restarted RStudio. Do I need to reboot?

[cderv]

Can you try to

• restart your R session
• reinstall the package with remotes::install_github("rnuske/komaletter#8")
• retry your rendering
  ?

I just got rid of grrfile for good here.

[jrennstich]

Keeps insisting
tlmgr search --file --global '/grffile.sty'
Rebooted the Mac, reinstalled from github.

[cderv]

🤦‍♂ There were two times grffile mentioned in the template.tex

I tested with the draft from this package and it works on my computer.

Sorry for that...

[jrennstich]

You're da bomb. Thanks so much1 Works perfectly now.

[cderv]

@rnuske this seems to work. I let you dig into the issue following all the linked and see if the current fix is what you want. There should be room for improvement as I am not expert in Latex and did not know you package before.
I was just trying to help @jrennstich with a quick fix.

Cheers.

[cderv]

It seems you can also wait for a stub in CTAN per this comment
rstudio/rmarkdown#1692 (comment)

[rnuske]

Thanks a ton @cderv for researching, answering and providing a fix for the issue!

[davidcarlisle]

This test doesn't really do any harm but (other than for a few hours due to a bug in the texlive distribution over the weekend) it will always be true as we still distribute grffile, it just does nothing other than include graphicx, specifically so the first version would still work without requiring any change.

[rnuske]

Thanks for the assessment @davidcarlisle.

Do you suggest the problem has already passed? Or might the grffile still be missing for sometime in Tex Live distributions of various Linux distributions due to time lags? In that case the test might be helpful for a certain time. But if the probability of missing grffile is very low it might be more sensible to take the test out again now.

[davidcarlisle]

that problem (that it was not in the texlive server at all) will have passed, it was only missing for a few hours so unless sites were regularly updating they would never have seen the issue, and if they have updated since, the issue has gone... however as grffile doesn't do anything now texlive may move it out of the latex-recommended collection to latex-extra so people installing a more minimal texlive may not have it installed locally (this possibility hadn't occurred to me when I made the original comment)