chore: bump iOS and Android dependencies to get latest bug fixes #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philter
commented
Apr 3, 2024
android/build.gradle
Outdated
| @@ -31,7 +31,7 @@ android { | |||
| compileSdkVersion getExtOrIntegerDefault('compileSdkVersion') | |||
| buildToolsVersion getExtOrDefault('buildToolsVersion') | |||
| defaultConfig { | |||
| minSdkVersion 21 | |||
| minSdkVersion 24 | |||
There was a problem hiding this comment.
This solved the following error:
Execution failed for task ':app:mergeExtDexDebug'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
> Failed to transform rive-android-9.2.2.aar (app.rive:rive-android:9.2.2) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-enable-jacoco-instrumentation=false, dexing-is-debuggable=true, dexing-min-sdk=21, org.gradle.category=library, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=androidJvm}.
> Execution failed for DexingWithClasspathTransform: /Users/philrive/.gradle/caches/transforms-3/defcb3a484b64167fc84e6cd1cef719b/transformed/jetified-rive-android-9.2.2-runtime.jar.
> Error while dexing.
> Failed to transform kotlin-stdlib-1.9.22.jar (org.jetbrains.kotlin:kotlin-stdlib:1.9.22) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-enable-jacoco-instrumentation=false, dexing-is-debuggable=true, dexing-min-sdk=21, org.gradle.category=library, org.gradle.jvm.environment=standard-jvm, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
> Execution failed for DexingWithClasspathTransform: /Users/philrive/.gradle/caches/transforms-3/755bc55d71b5f70c0d2fe3d2d5f63094/transformed/jetified-kotlin-stdlib-1.9.22.jar.
> Error while dexing.
There was a problem hiding this comment.
I believe we don't need to update the minSDKVersion here, and it'll only be needed in the example/build.gradle to get the example compiling.
I also suspect that there is just some other config we need to update in the example project, instead of bumping the minSDK.
android/build.gradle
Outdated
| @@ -135,7 +135,7 @@ dependencies { | |||
| implementation 'androidx.core:core-ktx:1.12.0' | |||
| implementation 'androidx.appcompat:appcompat:1.6.1' | |||
| implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.1' | |||
| implementation 'app.rive:rive-android:8.7.0' | |||
| implementation 'app.rive:rive-android:9.2.2' | |||
There was a problem hiding this comment.
🚀
Although, I think the latest is 9.3.0?
I haven't added any code in this commit to expose OOB to the React layer. Looks like @zplata had a start to it here for iOS. |
HayesGordon
approved these changes
Apr 3, 2024
|
Hi, is a new release with these changes coming soon? Thanks! |
|
@anirudhsama Release 7.0.0 has been published! |
|
Thank you very much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping iOS to 5.10.0 and Android 9.3.0
Notes: