Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more than 1KB for download test. #172

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Use more than 1KB for download test. #172

merged 1 commit into from
Dec 3, 2018

Conversation

timsifive
Copy link
Collaborator

This is a pretty old bug. I limited the size to 256KB because against
spike my machine gets about 8KB/s, and I don't want to wait forever for
make to pass.

This is a pretty old bug. I limited the size to 256KB because against
spike my machine gets about 8KB/s, and I don't want to wait forever for
`make` to pass.
@timsifive timsifive requested a review from cgsfv November 30, 2018 21:09
Copy link
Collaborator

@cgsfv cgsfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with a limit to keep test time reasonable.

@timsifive timsifive merged commit 58d61ef into master Dec 3, 2018
@timsifive timsifive deleted the downloadtest branch December 3, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants