Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize invoice / order date. #31

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Customize invoice / order date. #31

merged 5 commits into from
Apr 24, 2019

Conversation

tgensol
Copy link
Contributor

@tgensol tgensol commented Apr 24, 2019

Enable the creation date to be changed (As I needed to create an invoice for old orders)

@rimiti rimiti self-assigned this Apr 24, 2019
@rimiti
Copy link
Owner

rimiti commented Apr 24, 2019

Hi @tgensol,

In first, thank you for your contribution.
Could you please fix the CI (without changing the coding style) ? 🙏

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #31 into master will increase coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   85.36%   86.17%   +0.81%     
==========================================
  Files           7        7              
  Lines         246      246              
  Branches       69       69              
==========================================
+ Hits          210      212       +2     
+ Misses         25       24       -1     
+ Partials       11       10       -1
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/classes/generator.js 83.53% <100%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91095c...e13d3f5. Read the comment docs.

@tgensol
Copy link
Contributor Author

tgensol commented Apr 24, 2019

It was hard but finally I found out. But your editorconfig was not working with my VisualStudio :(

@rimiti rimiti merged commit 60aab0a into rimiti:master Apr 24, 2019
@rimiti rimiti added this to the v3.2.0 milestone Apr 24, 2019
@rimiti rimiti changed the title Date Customize invoice / order date. Apr 24, 2019
@rimiti
Copy link
Owner

rimiti commented Apr 24, 2019

@tgensol It's weird because the .editorconfig configuration is right.
Anyway, I just updated it.

Thanks for you work 🙏 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants