chain conversion #715
Merged
chain conversion #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groverlynn
force-pushed
the
chain_convert
branch
from
f09ca66
to
93760a8
Compare
groverlynn
force-pushed
the
chain_convert
branch
from
93760a8
to
5cb54f8
Compare
|
有點兒燒腦。 |
lotem
approved these changes
Feb 9, 2024
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #652 , improves #688
Feature
Improve chain conversion #688 . Specifically, this PR corrects the mistake that chain conversion only converts EXACT matched string while ignoring partially matched conversions.
E.g. previously, the exact matching results in
才能 (zh-Hans) -> 才能 & 纔能 (zh-Hant) -> 才能 & 纔能 (zh-TW, zh-HK), because it starts with exactly-matched才能 (zh-Hans) -> 才能 & 纔能 (zh-Hant), then ignores the partially-matched rule of纔 (zh-Hant) -> 才 (zh-TW, zh-HK). Now the conversion can get the correct result:才能 (zh-Hans) -> 才能 & 纔能 (zh-Hant) -> 才能 (zh-TW, zh-HK)Unit test
Manual test
Code Review
Additional Info