Handle case where data to be highlighted is None, and minor refactoring #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case where data of the field to be highlighted is None,
causing highlight method to fail since it expects data to be of string type. Fixes Highlighting fails with TypeError when highlighter_field value is None (while using HighlighterMixin) #155
Taking out the extraction of terms from the request into a method of its own,
namely
get_terms
so that its easier to override it with a custom implementation,adds to separation of concerns.