Added HMAC-SHA256 as a signature method to OAUTH1 #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good so far... you just need to add some unit tests then I can finish the review and get it merged in |
|
All of my unit tests pass now. I'm not sure when this failure is with the RestSharp.IntegrationTests.AsyncTests.Can_Cancel_GET_TaskAsync test... I never touched that one. |
|
There's something wrong with that test running in the CI environment. I've not figured it out yet. |
|
Do you need anything further from me on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed support for HMAC-SHA256 for a project