Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table column auto-sizing #7451

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Fix table column auto-sizing #7451

merged 4 commits into from
Sep 19, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 19, 2024

The bug was that the amount of allocated space was never reported up the Ui chain

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

The bug was that the amount of allocated space was never reported
up the `Ui` chain
@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 19, 2024
@abey79
Copy link
Member

abey79 commented Sep 19, 2024

edit: addressed in f46e045

It's still relatively easy to reach a "wrong width situation":

  • create a new dataframe view (single row showing since latest-at)
  • switch to "Define time range" (often still single row showing since the default PoV component is not the correct one)
  • chose a suitable PoV component -> many rows appear, several wrong column sizes

e.g.

image

This probably makes sense since we salt the table with the schema (which doesn't change between step 2 and 3). Maybe adding the pov component to the salt might be a good idea.

@abey79 abey79 self-requested a review September 19, 2024 12:43
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So neat to have well behaving columns!

@emilk emilk merged commit 38a442e into main Sep 19, 2024
33 checks passed
@emilk emilk deleted the emilk/fix-column-auto-sizing branch September 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants