Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyo3 in conjunction with arrow2::arrow and arrow-rs::pyarrow support #7322

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Aug 30, 2024

What

In preparation of:

We want to be able to use the arrow-rs pyarrow support to more easily move data bidirectionally between rust and python.

This required updating our pyo3 version, which required migrating some functions to use the new Bound<> APIs.

This allowed us to get rid of the old unsafe calls, though adds an extra step of going pyarrow -> arrow-rs -> arrow.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐍 Python API Python logging API dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 30, 2024
@jleibs jleibs marked this pull request as ready for review August 30, 2024 15:46
@teh-cmc
Copy link
Member

teh-cmc commented Aug 31, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/10646522823

@teh-cmc teh-cmc self-requested a review August 31, 2024 16:00
@teh-cmc
Copy link
Member

teh-cmc commented Aug 31, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/10646592777

@teh-cmc
Copy link
Member

teh-cmc commented Aug 31, 2024

Fantastic -- let's get this in sooner than later, we can release re_arrow2 at any time.

@teh-cmc teh-cmc merged commit cdd5966 into main Aug 31, 2024
67 of 68 checks passed
@teh-cmc teh-cmc deleted the jleibs/update_pyo3 branch August 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants