Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a ui issue where a visualiser would have both an override and default set for some component #7206

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 15, 2024

What

Component affected are all whose edit ui is based on ComboBox (or any widget that requires an egui id).

On a debug build, this would lead to this ID clash:

image

On a release build (e.g. 0.17), this would make the popup menu unusable in a weird way.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface include in changelog labels Aug 15, 2024
@Wumpf Wumpf merged commit d49d542 into main Aug 15, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the antoine/fix-visualizer-id-clash branch August 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants