Convert JS package to yarn workspace #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🕸️ web
teh-cmc
approved these changes
Feb 14, 2024
| @@ -165,6 +167,17 @@ pub fn build(profile: Profile, target: Target, build_dir: &Utf8Path) -> anyhow:: | |||
| if profile == Profile::Release { | |||
| eprintln!("Optimizing wasm with wasm-opt…"); | |||
|
|
|||
| if !std::process::Command::new("wasm-opt") | |||
There was a problem hiding this comment.
This command and the one below should really just be using Command::output and dump the child's stderr if !success().
That will also make the code much simpler.
jprochazk
added a commit
that referenced
this pull request
Feb 21, 2024
### What - [x] Move `web-viewer-react` package into its own folder at the same level as `web-viewer` - [x] Add a root `package.json` in `rerun_js` with `workspaces` property pointing at the two packages - [x] Update CI to use workspaces ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5160/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5160/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5160/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5160) - [Docs preview](https://rerun.io/preview/af65e980271dd584decd5ac1934443dd6a9fb86d/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/af65e980271dd584decd5ac1934443dd6a9fb86d/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
web-viewer-reactpackage into its own folder at the same level asweb-viewerpackage.jsoninrerun_jswithworkspacesproperty pointing at the two packagesChecklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io