Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load examples manifest via HTTP #4391

Merged
merged 29 commits into from
Dec 1, 2023
Merged

Load examples manifest via HTTP #4391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
4c5c3a4
load example manifest via http
jprochazk Nov 29, 2023
afee69a
override `EXAMPLES_MANIFEST_URL` at runtime in CLI
jprochazk Nov 29, 2023
7dfb188
move examples_manifest build script
jprochazk Nov 29, 2023
52e89ab
support `manifest_url` query param
jprochazk Nov 29, 2023
2b0ea81
support `--base-url` arg
jprochazk Nov 30, 2023
99b68d2
remove unused deps
jprochazk Nov 30, 2023
beed08f
add `build-examples-manifest` task to pixi
jprochazk Nov 30, 2023
09848dc
set default manifest to real values
jprochazk Nov 30, 2023
22daf12
build manifest on CI
jprochazk Nov 30, 2023
46921d0
fix clippy lints
jprochazk Nov 30, 2023
aee399f
get rid of `UPLOAD_COMMIT_OVERRIDE` dance
jprochazk Nov 30, 2023
1b9f878
fix trailing commas
jprochazk Nov 30, 2023
eb11397
ignore generated js file
jprochazk Nov 30, 2023
fc0807b
remove log about using default manifest
jprochazk Nov 30, 2023
43248c0
Merge branch 'main' into jan/online-manifest
jprochazk Nov 30, 2023
f9b14c6
update pr template with nightly app rerun io
jprochazk Nov 30, 2023
d3375b9
Merge branch 'main' into jan/online-manifest
jprochazk Nov 30, 2023
d8fa1ba
sort
jprochazk Nov 30, 2023
815bd94
move code around for readability
jprochazk Nov 30, 2023
c27c570
remove unnecessary `pub(crate)`
jprochazk Nov 30, 2023
9936fc7
use `ReUi::error_text` instead of plain `label` for error message
jprochazk Nov 30, 2023
7cd767e
remove unnecessary handle.start args
jprochazk Nov 30, 2023
1a39da1
downgrade prettier
jprochazk Nov 30, 2023
1b109a7
uppercase doctype
jprochazk Nov 30, 2023
252b6be
update pr template
jprochazk Nov 30, 2023
811b020
update pr template again
jprochazk Nov 30, 2023
50638c2
fix usage of `error_text`
jprochazk Nov 30, 2023
c6c2960
Merge branch 'main' into jan/online-manifest
jprochazk Nov 30, 2023
cf3b24b
Merge branch 'main' into jan/online-manifest
jprochazk Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix trailing commas
  • Loading branch information
@jprochazk
jprochazk committed Nov 30, 2023
commit 1b9f878b69ccebc88d2a14f885d145450f8be73d
10 changes: 5 additions & 5 deletions web_viewer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<!-- The version of index.html that will be served by app.rerun.io -->
<html>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
Expand Down Expand Up @@ -195,7 +195,7 @@
// On mobile platforms show a warning, but provide a link to try anyways
if (
/Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(
navigator.userAgent
navigator.userAgent,
)
) {
show_center_html(`
Expand Down Expand Up @@ -253,7 +253,7 @@
// If the content is gzip encoded, try to get the uncompressed size.
if (response.headers.get("content-encoding") == "gzip") {
content_length = response.headers.get(
"x-goog-meta-uncompressed-size"
"x-goog-meta-uncompressed-size",
);

// If the uncompressed size wasn't found 3 seems to be a very good approximation
Expand Down Expand Up @@ -285,7 +285,7 @@
{
status: response.status,
statusText: response.statusText,
}
},
);

for (const [key, value] of response.headers.entries()) {
Expand All @@ -309,7 +309,7 @@
typeof navigator.gpu === "undefined"
) {
console.debug(
"`navigator.gpu` is undefined. This indicates lack of WebGPU support."
"`navigator.gpu` is undefined. This indicates lack of WebGPU support.",
);
show_center_html(`
<p class="strong">
Expand Down
10 changes: 5 additions & 5 deletions web_viewer/index_bundled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<!-- The version of index.html bundled with the Rerun SDK. -->
<html>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
Expand Down Expand Up @@ -189,7 +189,7 @@
// On mobile platforms show a warning, but provide a link to try anyways
if (
/Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(
navigator.userAgent
navigator.userAgent,
)
) {
show_center_html(`
Expand Down Expand Up @@ -247,7 +247,7 @@
// If the content is gzip encoded, try to get the uncompressed size.
if (response.headers.get("content-encoding") == "gzip") {
content_length = response.headers.get(
"x-goog-meta-uncompressed-size"
"x-goog-meta-uncompressed-size",
);

// If the uncompressed size wasn't found 3 seems to be a very good approximation
Expand Down Expand Up @@ -279,7 +279,7 @@
{
status: response.status,
statusText: response.statusText,
}
},
);

for (const [key, value] of response.headers.entries()) {
Expand All @@ -303,7 +303,7 @@
typeof navigator.gpu === "undefined"
) {
console.debug(
"`navigator.gpu` is undefined. This indicates lack of WebGPU support."
"`navigator.gpu` is undefined. This indicates lack of WebGPU support.",
);
show_center_html(`
<p class="strong">
Expand Down