Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.1 #480

Merged
merged 7 commits into from
Feb 18, 2022
Merged

Release 1.3.1 #480

merged 7 commits into from
Feb 18, 2022

Conversation

JonathanHuot
Copy link
Contributor

After this MR is OK, we can tag the git commit, and it should (hopefully) automatically push the python package to pypi.
Have a look on changelog & new pipeline.

@JonathanHuot JonathanHuot added this to the 1.3.1 milestone Jan 21, 2022
@coveralls
Copy link

coveralls commented Jan 21, 2022

Coverage Status

Coverage remained the same at 90.239% when pulling bcbb876 on release-1.3.1 into 05a25a9 on master.

@JonathanHuot
Copy link
Contributor Author

Note that I avoided adding the automatic Github Release publishing, as I have too many Github Actions related to this... I was not able to choose, as none of them seems complete!

Basically, I was trying to replace the lovely TravisCI "releases" provider:

deploy:
  - provider: releases
    api_key:
      secure: "<..>"
    on:
      tags: true
      all_branches: true
      condition: $TOXENV = py36
      repo: requests/requests-oauthlib

@JonathanHuot
Copy link
Contributor Author

Pushing tag triggered the release in pypi as expected !
https://pypi.org/project/requests-oauthlib/1.3.1/

@jtroussard
Copy link
Contributor

I think we need to rethink our code coverage check, there is a bug I think on coverall side that causing these -0% coverage changes and creates these merge blocks. These are a few options:

  • workaround this and increase request-oauthlib coverall threshold to something like 0.01%
  • don't check all versions of python for coverage - should only really check for maintained and/or supported versions (this could still leave us with a version that is returning the -0% change)
  • Only run coverage against the latest version of python

lemurheavy/coveralls-public#1608 (comment)

@JonathanHuot

@jtroussard
Copy link
Contributor

@JonathanHuot - Circling back to this one here. Just needs a nudge to get it across the finish line. Who has access to the coveralls settings? Can we bump the coverage check threshold to 0.01% and run the pipeline against this release again?

@JonathanHuot
Copy link
Contributor Author

thanks to @nateprewitt, the coverage threshold has been changed to 1%, and now all checks are passing!

@jtroussard, the story about restoring pipeline is done finally. Now we can focus on bug & features PR reviews..

@JonathanHuot JonathanHuot merged commit 3431a1b into master Feb 18, 2022
JonathanHuot added a commit to Jackson-Woods/requests-oauthlib that referenced this pull request Feb 18, 2022
@JonathanHuot JonathanHuot deleted the release-1.3.1 branch February 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants