serve airgap bundles from Go container #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2019 22:14
The Go container handles /bundles and proxies everything else to the typescript server. The typescript server /bundles handler now returns a json manifest with a list of packages to extract and include plus a list of files with their contents, allowing the Go server to be a dumb component.
divolgin
reviewed
Oct 8, 2019
| w.Header().Set("Content-Encoding", "gzip") | ||
|
|
||
| wz := gzip.NewWriter(w) | ||
| archive := tar.NewWriter(wz) |
There was a problem hiding this comment.
defer wz.Close() and defer archive.Close() instead of closing them at the end. I'm not sure if these leak anything on the returns below, but they could
divolgin
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go container handles /bundles and proxies everything else to the
typescript server. The typescript server /bundles handler now returns a
json manifest with a list of packages to extract and include plus a list
of files with their contents, allowing the Go server to be a dumb
component.