rm_stm: do not hold producer lock for the duration of the barrier #17472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lock ensures that the concurrent idempotent requests do not reorder at the raft layer, i.e if one of the requests within a concurrent batch of dempotent requests fail to replicate, the subsequent ones fail too. Upon hitting an OOOSN, we do not need to hold the lock as we are waiting for the barrier as we know for a fact that request that acquired this lock is of invalid sequence and does not affect the concurrently running requests. Holding the lock while the barrier returns just delays legit concurrent requests.
|
I noticed this happening when debugging @nvartolomei 's write caching tests. |
mmaslankaprv
approved these changes
Apr 3, 2024
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock ensures that the concurrent idempotent requests do not reorder at the raft layer, i.e if one of the requests within a concurrent batch of dempotent requests fail to replicate, the subsequent ones fail too.
Upon hitting an OOOSN, we do not need to hold the lock as we are waiting for the barrier as we know for a fact that request that acquired this lock is of invalid sequence and does not affect the concurrently running requests. Holding the lock while the barrier returns just delays legit concurrent requests.
Backports Required
Release Notes