Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guideline #2958

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Update contribution guideline #2958

merged 5 commits into from
Mar 29, 2022

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #2958 (68f6715) into master (027f79a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2958      +/-   ##
============================================
- Coverage     53.72%   53.71%   -0.02%     
+ Complexity     3337     3336       -1     
============================================
  Files           217      217              
  Lines         13288    13288              
  Branches        774      774              
============================================
- Hits           7139     7137       -2     
- Misses         5902     5903       +1     
- Partials        247      248       +1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Protocol.java 88.12% <0.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027f79a...68f6715. Read the comment docs.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions @sazzad16

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@sazzad16 sazzad16 requested a review from chayim March 27, 2022 08:39
dengliming
dengliming previously approved these changes Mar 27, 2022
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@sazzad16 sazzad16 merged commit 83af8c1 into master Mar 29, 2022
@sazzad16 sazzad16 deleted the sazzad16-contributing branch March 29, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants