Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(must-gather): Updates gather script to collect pod spec of non-runing pods #325

Merged

Conversation

ashishranjan738
Copy link
Contributor

This commit updates gather script to collect pod spec of non-running pods.

Signed-off-by: Ashish Ranjan [email protected]

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2019
@ashishranjan738 ashishranjan738 changed the title enhance(must-gather): Updates gather script to collect pod spec of non-runing pods fix(must-gather): Updates gather script to collect pod spec of non-runing pods Nov 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@ashishranjan738
Copy link
Contributor Author

/test ocs-operator-e2e-aws

@ashishranjan738
Copy link
Contributor Author

/retest

@obnoxxx
Copy link
Contributor

obnoxxx commented Nov 25, 2019

/test ocs-operator-e2e-aws

@ashishranjan738
Copy link
Contributor Author

Need Backporting for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1775059

@obnoxxx
Copy link
Contributor

obnoxxx commented Nov 25, 2019

/retest

This commit updates gather script to collect pod spec of non-running pods.

Signed-off-by: Ashish Ranjan <[email protected]>
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashishranjan738, obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@obnoxxx
Copy link
Contributor

obnoxxx commented Nov 25, 2019

as discussed, in the future please separate actual changes from cleanups/general improvements of code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants