-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(must-gather): updates collection script to collect CLBO pod logs #324
fix(must-gather): updates collection script to collect CLBO pod logs #324
Conversation
This commit fixes must-gather collection scripts to collect CLBO pod logs which were earlier getting missed. Signed-off-by: Ashish Ranjan <[email protected]>
addf698
to
929bb6c
Compare
Needs backporting for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1770941 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashishranjan738, jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Discussed this with @ashishranjan738 ; there is an unlikely case here of a pod being excluded if its name contains or is the word "Running", but this can be addressed as a separate and more minor issue. |
/cherrypick release-4.2 |
@obnoxxx: #324 failed to apply on top of branch "release-4.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit fixes must-gather collection scripts to collect CLBO pod logs which were earlier getting missed.
Note: Shifted to inverted grep for now as CLBO pods also have
status.Phase
asRunning
because of which--field-selector
was not able to grab the crashLoopBackOff pods.Signed-off-by: Ashish Ranjan [email protected]