Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(must-gather): updates collection script to collect CLBO pod logs #324

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

ashishranjan738
Copy link
Contributor

@ashishranjan738 ashishranjan738 commented Nov 25, 2019

This commit fixes must-gather collection scripts to collect CLBO pod logs which were earlier getting missed.

Note: Shifted to inverted grep for now as CLBO pods also have status.Phase as Running because of which --field-selector was not able to grab the crashLoopBackOff pods.

Signed-off-by: Ashish Ranjan [email protected]

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2019
This commit fixes must-gather collection scripts to collect CLBO pod logs which were earlier getting missed.

Signed-off-by: Ashish Ranjan <[email protected]>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@ashishranjan738
Copy link
Contributor Author

Needs backporting for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1770941

Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashishranjan738, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@egafford
Copy link
Contributor

Discussed this with @ashishranjan738 ; there is an unlikely case here of a pod being excluded if its name contains or is the word "Running", but this can be addressed as a separate and more minor issue.

@obnoxxx
Copy link
Contributor

obnoxxx commented Nov 25, 2019

/cherrypick release-4.2

@openshift-cherrypick-robot

@obnoxxx: #324 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	must-gather/collection-scripts/gather_ceph_resources
Falling back to patching base and 3-way merge...
Auto-merging must-gather/collection-scripts/gather_ceph_resources
CONFLICT (content): Merge conflict in must-gather/collection-scripts/gather_ceph_resources
Patch failed at 0001 fix(must-gather): updates collection script to collect CLBO pod logs

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants