Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ocs-metrics-exporter to use the correct image name #1697

Merged

Conversation

malayparida2000
Copy link
Contributor

Currently the ocs-metrics-exporter-image is set to use the ocs-image.
Which is resulting in the ocs-metrics-exporter deployment failing, which
in turn results in failing of the ocs operator csv. So changing it to use the correct image

Currently the ocs-metrics-exporter-image is set to use the ocs-image.
Which is resulting in the ocs-metrics-exporter deployment failing, which
in turn results in failing of the ocs operator csv

Signed-off-by: Malay Kumar Parida <[email protected]>
This includes changes to the ocs operator csv file after changing the
ocs-metrics-exporter-image.

Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000 malayparida2000 changed the title Fix metric exporter Change ocs-matric-exporter to use the correct image name May 26, 2022
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@malayparida2000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws e6d6752 link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jarrpa jarrpa changed the title Change ocs-matric-exporter to use the correct image name Change ocs-metrics-exporter to use the correct image name May 26, 2022
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, jarrpa, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@openshift-merge-robot openshift-merge-robot merged commit 98d2b32 into red-hat-storage:main May 26, 2022
@malayparida2000 malayparida2000 deleted the fix_metric_exporter branch August 17, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants