Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotation to enable add-capacity for csv #1681

Conversation

SanjalKatiyar
Copy link
Contributor

Removed a flag which is disabling UI components in Console.
Used to track migration of features from OCP to ODF.
Signed-off-by: SanjalKatiyar [email protected]

Removed a flag which is disabling UI components in Console.
Used to track migration of features from OCP to ODF.
Signed-off-by: SanjalKatiyar <[email protected]>
@SanjalKatiyar
Copy link
Contributor Author

Do not merge right now... waiting for openshift/console#11515 to get closed before merging.
not adding hold tag otherwise CI will not run.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@SanjalKatiyar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws f59d2c0 link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@SanjalKatiyar
Copy link
Contributor Author

@umangachapagain plz merge this. Thanks.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit af5d548 into red-hat-storage:main May 19, 2022
@SanjalKatiyar
Copy link
Contributor Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1685

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants