Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocs to ocs : provider api server #1423

Merged
merged 4 commits into from
Dec 13, 2021
Merged

ocs to ocs : provider api server #1423

merged 4 commits into from
Dec 13, 2021

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Dec 4, 2021 •
edited
Loading

This PR
Adds protobuf and generated grpc code.
Adds server and client stubs
Adds api server to the OCS operator image

@sp98
Copy link
Contributor Author

sp98 commented Dec 6, 2021

/retest

@sp98 sp98 force-pushed the provider-api-server branch 4 times, most recently from dc36262 to 85f6f90 Compare December 8, 2021 01:41
@jarrpa
Copy link
Member

jarrpa commented Dec 8, 2021 •
edited
Loading

@sp98 CI changes look valid. Please make sure to run make ocs-operator-ci before pushing and see if they occur on your local system.

@sp98
ocs-to-ocs: Implement API server boilerplate
f6bff2a 
Using gRPC to implement the API server for communication between
Consumer and Provider cluster

Signed-off-by: Santosh Pillai <[email protected]>
@sp98
ocs-to-ocs: go mod and vendor changes for gRPC
80091db 
Signed-off-by: Santosh Pillai <[email protected]>
@sp98
ocs-to-ocs: Add server and client stub
2d1e119 
This PR adds server and client stubs for the Consumer API server.
The server methods are not implemented yet.

Signed-off-by: Santosh Pillai <[email protected]>
@sp98
ocs-to-ocs: add provider api-server to ocs operator image
b7ce0ff 
This PR:
- builds the provider api at _output/bin/provider-api
- Copies the build in the ocs operator image at
  user/local/bin/provider-api

Signed-off-by: Santosh Pillai <[email protected]>
@sp98
Copy link
Contributor Author

sp98 commented Dec 9, 2021 •
edited
Loading

@sp98 CI changes look valid. Please make sure to run make ocs-operator-ci before pushing and see if they occur on your local system.

I'd removed one import from the proto file but didn't run go mod vendor after that. Updated the PR. I think it should be ok now.

@sp98
Copy link
Contributor Author

sp98 commented Dec 11, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2021

@sp98: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws b7ce0ff link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jarrpa
jarrpa approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@jarrpa jarrpa merged commit 97dd701 into red-hat-storage:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@umangachapagain umangachapagain Awaiting requested review from umangachapagain

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sp98 @jarrpa