You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But as far as I undestand, we shoud wrap the yield into a try: block with the close in the finally:, otherwise a exception might allow leaving the with block without calling close. I might do a PR for this, but I wanted to check with someone if there was a reason the code was shown this way and/or if I was mistaken altogether...
The text was updated successfully, but these errors were encountered:
So what's said here is :
But as far as I undestand, we shoud wrap the
yield
into atry:
block with theclose
in thefinally:
, otherwise a exception might allow leaving thewith
block without callingclose
. I might do a PR for this, but I wanted to check with someone if there was a reason the code was shown this way and/or if I was mistaken altogether...The text was updated successfully, but these errors were encountered: