Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert missing set_xcode_and_swift_versions #4669

Merged
merged 1 commit into from
Feb 14, 2017
Merged

insert missing set_xcode_and_swift_versions #4669

merged 1 commit into from
Feb 14, 2017

Conversation

larkost
Copy link
Contributor

@larkost larkost commented Feb 14, 2017

No description provided.

@larkost larkost self-assigned this Feb 14, 2017
@larkost larkost requested a review from jpsim February 14, 2017 22:50
@larkost
Copy link
Contributor Author

larkost commented Feb 14, 2017

The two failures look unrelated (test failures), so I think this one can go in.

@jpsim jpsim added the S:Review label Feb 14, 2017
jpsim
jpsim approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cocoa-pipeline run looks promising: https://ci.realm.io/job/cocoa-pipeline/157

Thanks @larkost!

@jpsim jpsim merged commit c4d1717 into master Feb 14, 2017
@jpsim jpsim deleted the larkost/4652-fix branch February 14, 2017 23:22
@jpsim jpsim removed the S:Review label Feb 14, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees

@larkost larkost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larkost @jpsim