Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Appledoc target #365

Merged
merged 2 commits into from
Jun 3, 2014
Merged

Adding Appledoc target #365

merged 2 commits into from
Jun 3, 2014

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jun 2, 2014

This PR moves the generation of documentation from build.sh to Xcode.

@emanuelez @jpsim @alazier @timanglade @bmunkholm

@alazier
Copy link
Contributor

alazier commented Jun 2, 2014

looks fine 👍

@jpsim
Copy link
Contributor

jpsim commented Jun 2, 2014

Looks good, but since we've separated the shell scripts into multiple files, I'd like to put them in a scripts/ directory. Do that and 👍!

@timanglade
Copy link
Contributor

The build.sh commands have changed significantly in the ta-fix-docs branch. Can you base this branch off of that branc instead? (Trying to merge it into master today.)

@alazier
Copy link
Contributor

alazier commented Jun 3, 2014

Why have we not merged ta-fix-docs? For big changes like this that touch
all the headers it usually isn't a good idea to wait too long...

On Mon, Jun 2, 2014 at 4:54 PM, Tim Anglade [email protected]
wrote:

The build.sh commands have changed significantly in the ta-fix-docs
branch. Can you use that instead? (Trying to merge it into master today.)


Reply to this email directly or view it on GitHub
#365 (comment).

@timanglade
Copy link
Contributor

It’s my fault. I tried to pass the tests for it once Wednesday and once Friday but the core wasn’t compiling either time. I’m working on it now.

@kneth
Copy link
Contributor Author

kneth commented Jun 3, 2014

@timanglade I'll pull your changes into this branch and see how it goes.

@kneth
Copy link
Contributor Author

kneth commented Jun 3, 2014

@timanglade I have merged your branch into mine - and moved the changes to build-doc.sh. You're welcome to merge with master if everything is fine.

@bmunkholm
Copy link
Contributor

If we don't have the scripts inside xcode, we should keep them in build.sh instead of making multiple scripts.

@timanglade
Copy link
Contributor

👍 merging. I will move all scripts to a separate folder and clean up the scheme names in a separate PR.

timanglade added a commit that referenced this pull request Jun 3, 2014
@timanglade timanglade merged commit 4c83683 into master Jun 3, 2014
@emanuelez emanuelez deleted the kg-appledoc-in-xcode branch July 2, 2014 08:24
jpsim pushed a commit that referenced this pull request Sep 27, 2016
Fix bug where opening Realm with access token deadlocks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants