Remove Processors from public API #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simonbasle
commented
May 24, 2022
simonbasle
commented
- WIP clean up and remove processors from PUBLIC api
- Rename ReplayProcessor to SinkManyReplayProcessor
- Remove AbstractProcessorVerification tck
- fix compile error post merge
- remove processor mention in core.publisher.package-info
- Renamed EmitterProcessor->SinkManyEmitterProcessor + clean up
- polish: remove Processor mentions from documentation and strings, remove DirectInnerContainer...
…ove DirectInnerContainer...
simonbasle
added
type/chores
OlegDokuka
approved these changes
May 24, 2022
|
locally also verified javadoc generation and asciidoc generation (and fixed a couple issues in there) |
OlegDokuka
added a commit
that referenced
this pull request
May 31, 2022
This reverts commit 178e0c7.
simonbasle
added a commit
that referenced
this pull request
Jul 8, 2022
This partially reverts #3051, by reintroducing Flux Processors implementation as they were in 3.4.x (still deprecated). This was done by copying the classes and making a few small adaptations to DirectProcessor and SinkManyBestEffort (reintroducing the interface DirectInnerContainer, as a package-private mean of mutualizing the DirectInner code). This soft-revert doesn't reintroduce the MonoProcessor, which was also deleted as part of the above PR.
simonbasle
added a commit
that referenced
this pull request
Jul 8, 2022
This partially reverts #3051, by reintroducing Flux Processors implementation as they were in 3.4.x (still deprecated). This was done by copying the classes and making a few small adaptations to DirectProcessor and SinkManyBestEffort (reintroducing the interface DirectInnerContainer, as a package-private mean of mutualizing the DirectInner code). This soft-revert doesn't reintroduce the MonoProcessor, which was also deleted as part of the above PR.
simonbasle
added a commit
that referenced
this pull request
Jul 8, 2022
This partially reverts #3051, by reintroducing Flux Processors implementation as they were in 3.4.x (still deprecated). This was done by copying the classes and making a few small adaptations to DirectProcessor and SinkManyBestEffort (reintroducing the interface DirectInnerContainer, as a package-private mean of mutualizing the DirectInner code). This soft-revert doesn't reintroduce the MonoProcessor, which was also deleted as part of the above PR.
simonbasle
added a commit
that referenced
this pull request
Jul 11, 2022
This mostly reverts #3051, by reintroducing Flux and Mono Processor implementation as they were in 3.4.x (still deprecated). This was done by copying the classes and making a few small adaptations to DirectProcessor and SinkManyBestEffort (reintroducing the interface DirectInnerContainer, as a package-private mean of mutualizing the DirectInner code). This soft-revert doesn't reintroduce tests, Flux|Mono-level APIs or mentions in the documentation / reference guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.