Introduce an alternative to Processor-with-upstream case #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
added
type/enhancement
OlegDokuka
reviewed
May 19, 2022
reactor-core/src/main/java/reactor/core/publisher/EmitterProcessor.java
Outdated
Show resolved
Hide resolved
OlegDokuka
approved these changes
May 19, 2022
simonbasle
added a commit
that referenced
this pull request
May 23, 2022
OlegDokuka
added a commit
that referenced
this pull request
May 31, 2022
…)" This reverts commit b07f391.
simonbasle
added a commit
that referenced
this pull request
Jun 7, 2022
This commit reworks #3042 and reverts the changes to RootSpec returning methods. These changes were binary incompatible with the previous release of reactor, despite an API-compatible change. What is reverted: - the `UnsafeRootSpec` and intermediate specs are removed - `Sinks.unsafe()` is back to returning `RootSpec` What is kept: - `RootSpec` is dedicated to `Sinks.unsafe()` - `Sinks.manyWithUpstream` interface is still introduced What is modified: - `RootSpec` receives an additional `manyWithUpstream()` method which is the one exposing `Sinks.manyWithUpstream` implementations
simonbasle
added a commit
that referenced
this pull request
Jun 7, 2022
This commit reworks #3042 and reverts the changes to RootSpec returning methods. These changes were binary incompatible with the previous release of reactor, despite an API-compatible change. What is reverted: - the `UnsafeRootSpec` and intermediate specs are removed - `Sinks.unsafe()` is back to returning `RootSpec` What is kept: - `RootSpec` is dedicated to `Sinks.unsafe()` - `Sinks.manyWithUpstream` interface is still introduced What is modified: - `RootSpec` receives an additional `manyWithUpstream()` method which is the one exposing `Sinks.manyWithUpstream` implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a migration path for a subset of Processors (namely the
EmitterProcessor) before they get removed from the public API in 3.5.0.The
ManyUpstreamAdapteris a Processor-adjactent API that doesn't exposethe
CoreSubscriberAPI but rather separates concerns:Publisheraspect viaasFlux()(similar toSinks.Many)subscribeTo(Publisher)This way, the underlying
CoreSubscribernature is never revealed to the userwhich avoids the trouble with non-serialized access.
Emitter-like variants are exposed via
Sinks.unsafe().manyToUpstream()as
.onBackpressureBuffer(...)variants mirroring the ones inMulticastSpec.questions
ReplayProcessoralso be added? (IIRC it also kindof supports the "subscribe-to-upstream-and-respect-downstream-backpressure"
use case) => for now, focusing on EmitterProcessor