Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting #284

Closed
claydiffrient opened this issue Dec 26, 2016 · 1 comment
Closed

Linting #284

claydiffrient opened this issue Dec 26, 2016 · 1 comment
Assignees
@diasbruno @claydiffrient
Labels
discussion

Comments

@claydiffrient
Copy link
Contributor

Previously #90 was requested, but relied on what seems to be a deprecated config file.

I've had success using the AirBnB config in the past.

Thoughts?
@diasbruno
Copy link
Collaborator

That's awesome. We can also write a hook to check lint before commit.

$ npm run config # prepare hooks and extra stuff.

claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make travis run the lint task as well as specs
03991ab 
closes #284
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make travis run the lint task as well as specs
e08d386 
closes #284
@claydiffrient claydiffrient mentioned this issue Dec 31, 2016
Merged
5 tasks
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make travis run the lint task as well as specs
0633ff7 
closes #284
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make travis run the lint task as well as specs
0b10b56 
closes #284
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Make travis run the lint task as well as specs
c481226 
closes #284
claydiffrient added a commit that referenced this issue Dec 31, 2016
@claydiffrient
Add Linting (#293)
596f423 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
closes #286

* Make travis run the lint task as well as specs

closes #284
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 13, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
27ec79b 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
7bd3063 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit to diasbruno/react-modal that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (reactjs#293)
96668ba 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes reactjs#289
closes reactjs#286

* Make travis run the lint task as well as specs

closes reactjs#284
diasbruno pushed a commit that referenced this issue Jun 15, 2017
@claydiffrient @diasbruno
Add Linting (#293)
1c326a1 
* Add linting

* Make specs pass linter

* Make lib/helpers pass linter

* Make lib/components pass linter

This also does some signfiicant refactoring of the code
to appease the linter's pro-ES2015+ stance.

closes #289
closes #286

* Make travis run the lint task as well as specs

closes #284
This was referenced Jan 8, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this issue May 5, 2021
Open
@snyk-bot snyk-bot mentioned this issue May 26, 2021
Open
@snyk-bot snyk-bot mentioned this issue Oct 31, 2022
Open
@kamalaknn kamalaknn mentioned this issue Nov 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diasbruno diasbruno

@claydiffrient claydiffrient

Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diasbruno @claydiffrient