Add ability to update notification props by key #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhen-hryhorevskyi
force-pushed
the
master
branch
from
b288610
to
6edb5ad
Compare
|
Related ant-design/ant-design#8021 |
|
Cool, thanks. So, would this PR merged and published with a new version
(like `3.0.2`) nearest time or not?
|
|
Published as 3.1.0, could you send a PR to ant-design to upgrade its dependencies. |
|
Here is a PR for that: ant-design/ant-design#10089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
thank you for such small and useful library to manage notification messages.
I'm using it for my current project and like it very much.
I faced the situation when our UX requires an ability to update rendered notice content. Unfortunately, all my tries to update notification using its key failed. That is why I dug into the code and make a small update to be able to update rendered notice properties.
I've added required changes, example, test.
Here how it looks like: