Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

login attempts are now logged #159

Merged
merged 2 commits into from
May 24, 2016
Merged

login attempts are now logged #159

merged 2 commits into from
May 24, 2016

Conversation

philippks
Copy link
Contributor

Logs attempts to login and displays them on the main view:
image

Plus Index for Login Attempts:
image

@pencil
Copy link
Member

pencil commented May 8, 2016

Thanks, this looks awesome!

There is one minor problem: Usernames in CASino are not unique. Technically the same username can be used by different authentication backends. I see two possible solutions for this:

a) No longer allow duplicated usernames and make them unique. This would require a new major release since it's not backward compatible.
b) Log failed login attempts to all existing user account. Log successful attempts to the actual account that logged in.

@philippks
Copy link
Contributor Author

philippks commented May 9, 2016

Hey @pencil, thank you for your feedback!

After discussing with @calmyournerves, we think it is not in scope of CASino to care about the uniqueness of the usernames over multiple authenticators. So your secondly proposed solution is more pragmatically. I will make the corresponding changes.

@calmyournerves
Copy link
Contributor

@pencil did you already have a chance to look at this again? Thanks!

@pencil pencil merged commit 0e6cb68 into rbCAS:master May 24, 2016
@pencil
Copy link
Member

pencil commented May 24, 2016

Awesome, thanks.

@born4new born4new deleted the audit-log branch February 9, 2017 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants