This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Added option to require service rules when a service URL is specified #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the use case of an SSO that does not allow any services? Or is it to mitigate an accidental deletion of all service rules that would lead to accepting all services? |
|
hi @pencil - exactly: it's to mitigate against accidentally accepting all services. |
|
@pencil IMHO i think this would even be sane default, no? |
pencil
added a commit
that referenced
this pull request
Nov 4, 2015
Added option to require service rules when a service URL is specified
|
Setting this as default would probably cause a massive influx of bug reports. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to allow authentication from any service if no rules have been setup. The default is to allow this, but the new option makes sure that a rule is matched -- otherwise, login is disallowed.