Skip to content

Commit

Permalink
nfc(api): Port over ComponentName#dumpDebug to internal util
Browse files Browse the repository at this point in the history
Bug: 263564478
Test: Compiles
Change-Id: Ie8e54fb86d90b3f908273554d0c54b6ebbb0a82a
  • Loading branch information
rpius committed Feb 27, 2023
1 parent 3a4dcbf commit 8c864f7
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/java/android/nfc/cardemulation/ApduServiceInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
* @param proto the ProtoOutputStream to write to
*/
public void dumpDebug(ProtoOutputStream proto) {
getComponent().dumpDebug(proto, ApduServiceInfoProto.COMPONENT_NAME);
Utils.dumpDebugComponentName(getComponent(), proto, ApduServiceInfoProto.COMPONENT_NAME);
proto.write(ApduServiceInfoProto.DESCRIPTION, getDescription());
proto.write(ApduServiceInfoProto.ON_HOST, mOnHost);
if (!mOnHost) {
Expand Down
2 changes: 1 addition & 1 deletion core/java/android/nfc/cardemulation/NfcFServiceInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
* @param proto the ProtoOutputStream to write to
*/
public void dumpDebug(ProtoOutputStream proto) {
getComponent().dumpDebug(proto, NfcFServiceInfoProto.COMPONENT_NAME);
Utils.dumpDebugComponentName(getComponent(), proto, NfcFServiceInfoProto.COMPONENT_NAME);
proto.write(NfcFServiceInfoProto.DESCRIPTION, getDescription());
proto.write(NfcFServiceInfoProto.SYSTEM_CODE, getSystemCode());
proto.write(NfcFServiceInfoProto.NFCID2, getNfcid2());
Expand Down
37 changes: 37 additions & 0 deletions core/java/android/nfc/cardemulation/Utils.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Copyright (C) 2023 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package android.nfc.cardemulation;

import android.annotation.NonNull;
import android.content.ComponentName;
import android.content.ComponentNameProto;
import android.util.proto.ProtoOutputStream;

/** @hide */
public final class Utils {
private Utils() {
}

/** Copied from {@link ComponentName#dumpDebug(ProtoOutputStream, long)} */
public static void dumpDebugComponentName(
@NonNull ComponentName componentName, @NonNull ProtoOutputStream proto, long fieldId) {
final long token = proto.start(fieldId);
proto.write(ComponentNameProto.PACKAGE_NAME, componentName.getPackageName());
proto.write(ComponentNameProto.CLASS_NAME, componentName.getClassName());
proto.end(token);
}
}

0 comments on commit 8c864f7

Please sign in to comment.