Added extra where clause to known variable #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked for a successful login only
|
Is this working the way I assume you want it to? You want it to send a new device notification on login after a failed login attempt correct? If that's the case, I can't get it to work because it finds the previous successful attempt thus $known is true and it doesn't fire the notification. |
|
I would like it to fire a successful login after a failed login on an unknown (new) device. A successful login email is not needed on a known device after a failure. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked for a successful login only.
When a failed login attempt happens the user can receive a notification stating it failed. However, if that same device then successfully signs in the user is not informed about the successful login. From a security stand point the user doesn't know that the bad actor gained access after a failed attempt.