Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSP fix route return #1412

Merged
merged 2 commits into from
Feb 17, 2021
Merged

TSP fix route return #1412

merged 2 commits into from
Feb 17, 2021

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Feb 17, 2021

The vertex list that was fed as input to TSP was of type int64 which ended up being corrupted when passed down
to the cpp layer as vtx_ptr. I updated the wrapper to cast the vertices to int32. In addition, I fixed the handling of nstart in the wrapper which was assuming vertex ids were starting at 1.
Solves: #1410

@hlinsen hlinsen requested a review from a team as a code owner February 17, 2021 01:03
@hlinsen hlinsen changed the title TSP bug fix TSP fix route return Feb 17, 2021
@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #1412 (0e6c95d) into branch-0.18 (2fb0725) will increase coverage by 0.40%.
The diff coverage is 58.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #1412      +/-   ##
===============================================
+ Coverage        60.38%   60.78%   +0.40%     
===============================================
  Files               67       70       +3     
  Lines             3029     3134     +105     
===============================================
+ Hits              1829     1905      +76     
- Misses            1200     1229      +29     
Impacted Files Coverage Δ
python/cugraph/centrality/__init__.py 100.00% <ø> (ø)
python/cugraph/dask/structure/renumber.py 0.00% <0.00%> (ø)
python/cugraph/link_analysis/pagerank.py 100.00% <ø> (ø)
python/cugraph/traversal/__init__.py 100.00% <ø> (ø)
python/cugraph/traversal/sssp.py 93.63% <ø> (ø)
python/cugraph/traversal/traveling_salesperson.py 84.61% <ø> (ø)
python/cugraph/utilities/utils.py 72.44% <ø> (+0.88%) ⬆️
python/cugraph/comms/comms.py 34.52% <25.00%> (ø)
python/cugraph/dask/common/input_utils.py 23.07% <28.57%> (+1.14%) ⬆️
python/cugraph/dask/common/mg_utils.py 37.50% <38.09%> (-2.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78f3cb...6d315ae. Read the comment docs.

@BradReesWork BradReesWork changed the base branch from branch-0.19 to branch-0.18 February 17, 2021 14:06
@BradReesWork BradReesWork requested review from a team as code owners February 17, 2021 14:06
@BradReesWork BradReesWork changed the base branch from branch-0.18 to branch-0.19 February 17, 2021 14:07
@BradReesWork BradReesWork added bug Something isn't working non-breaking Non-breaking change labels Feb 17, 2021
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@ajschmidt8 ajschmidt8 removed the request for review from a team February 17, 2021 15:45
@hlinsen hlinsen changed the base branch from branch-0.19 to branch-0.18 February 17, 2021 16:32
@hlinsen
Copy link
Contributor Author

hlinsen commented Feb 17, 2021

rerun tests

@BradReesWork BradReesWork added this to the 0.18 milestone Feb 17, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cb2d841 into rapidsai:branch-0.18 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] traveling_salesperson route returned does not include all vertices
4 participants