-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSP fix route return #1412
TSP fix route return #1412
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1412 +/- ##
===============================================
+ Coverage 60.38% 60.78% +0.40%
===============================================
Files 67 70 +3
Lines 3029 3134 +105
===============================================
+ Hits 1829 1905 +76
- Misses 1200 1229 +29
Continue to review full report at Codecov.
|
Removing |
rerun tests |
@gpucibot merge |
The vertex list that was fed as input to TSP was of type
int64
which ended up being corrupted when passed downto the cpp layer as
vtx_ptr
. I updated the wrapper to cast the vertices toint32
. In addition, I fixed the handling of nstart in the wrapper which was assuming vertex ids were starting at 1.Solves: #1410