Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] enable multigraph #1280

Merged
merged 10 commits into from
Jan 21, 2021
Merged

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Nov 24, 2020

No description provided.

@Iroy30 Iroy30 requested a review from a team as a code owner November 24, 2020 16:02
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork added this to the 0.18 milestone Nov 24, 2020
@BradReesWork BradReesWork added the feature request New feature or request label Nov 24, 2020
@Iroy30 Iroy30 changed the title [WIP][skip-ci] enable multigraph [REVIEW] enable multigraph Dec 2, 2020
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #1280 (b6fa160) into branch-0.17 (6b92349) will increase coverage by 0.32%.
The diff coverage is 91.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #1280      +/-   ##
===============================================
+ Coverage        60.38%   60.70%   +0.32%     
===============================================
  Files               67       67              
  Lines             3029     3031       +2     
===============================================
+ Hits              1829     1840      +11     
+ Misses            1200     1191       -9     
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/structure/graph.py 68.33% <80.00%> (+1.54%) ⬆️
python/cugraph/structure/__init__.py 100.00% <100.00%> (ø)
python/cugraph/structure/symmetrize.py 73.33% <100.00%> (+2.60%) ⬆️
python/cugraph/traversal/sssp.py 93.63% <100.00%> (ø)
python/cugraph/utilities/utils.py 71.79% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b92349...b6fa160. Read the comment docs.

@BradReesWork BradReesWork added the non-breaking Non-breaking change label Jan 6, 2021
@BradReesWork BradReesWork requested review from afender, a team and BradReesWork and removed request for a team January 6, 2021 15:06
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is best to capture our multigraph discussions in the form of multigraph class documentation and add it as part of this PR from the start while it is still fresh in our mind.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor requests.

python/cugraph/structure/graph.py Outdated Show resolved Hide resolved
python/cugraph/structure/graph.py Show resolved Hide resolved
python/cugraph/structure/graph.py Outdated Show resolved Hide resolved
python/cugraph/structure/symmetrize.py Show resolved Hide resolved
python/cugraph/structure/symmetrize.py Show resolved Hide resolved
python/cugraph/tests/test_multigraph.py Outdated Show resolved Hide resolved
python/cugraph/tests/test_multigraph.py Show resolved Hide resolved
@BradReesWork BradReesWork merged commit da66ecf into rapidsai:branch-0.17 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants