Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong make uninstall command #9494

Merged
merged 1 commit into from
Feb 24, 2018

Conversation

giuscri
Copy link
Contributor

@giuscri giuscri commented Feb 24, 2018

This should fix #9486

make tries to cd to a no longer-existent directory, using a never existed ./libr/sysregs/d/Makefile

Line was introduced at 18c633c, but git log --all --full-history -- ./libr/sysregs/d/Makefile doesn't return anything and the only reference to sysregs in a Makefile seems to be trying to copy files that are not found in sysregs/d

$ grep -Hrn '.*sysregs.*'|grep Makefile
.git/COMMIT_EDITMSG:4:using a never existed `./libr/sysregs/d/Makefile`
Makefile:131:	mkdir -p "${WINDIST}/share/radare2/${VERSION}/sysregs"
Makefile:132:	cp -f libr/sysregs/d/*.sdb "${WINDIST}/share/radare2/${VERSION}/sysregs"

It tried to cd to a no longer-existent directory,
using a never existed `./libr/sysregs/d/Makefile`
@radare radare merged commit 8bf8d7f into radareorg:master Feb 24, 2018
SakiiR pushed a commit to SakiiR/radare2 that referenced this pull request Jul 1, 2019
It tried to cd to a no longer-existent directory,
using a never existed `./libr/sysregs/d/Makefile`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make uninstall fails to complete - tries to cd to non-existent dir libr/sysregs/d
2 participants