-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Azure Devops from git-plugin and prepare for other Git providers #30
Merged
martinvisser
merged 20 commits into
rabobank:main
from
MartinKanters:feature/make-git-plugin-extensible
Jul 25, 2023
Merged
Decouple Azure Devops from git-plugin and prepare for other Git providers #30
martinvisser
merged 20 commits into
rabobank:main
from
MartinKanters:feature/make-git-plugin-extensible
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-plugin/src/main/kotlin/io/rabobank/ret/git/plugin/command/PullRequestOpenCommand.kt
Show resolved
Hide resolved
git-plugin/src/main/kotlin/io/rabobank/ret/git/plugin/provider/GitUrlFactory.kt
Show resolved
Hide resolved
GuusdeWit
reviewed
Jun 30, 2023
git-plugin/src/main/kotlin/io/rabobank/ret/git/plugin/provider/GitUrlFactory.kt
Outdated
Show resolved
Hide resolved
This was referenced Jul 12, 2023
BrowserUtils: add the possibility to open URLs instead of Strings.
rabobank/ret-engineering-tools#63
Merged
martinvisser
previously approved these changes
Jul 24, 2023
martinvisser
previously approved these changes
Jul 24, 2023
GuusdeWit
approved these changes
Jul 24, 2023
…ed directly anymore from other places than the azure package.
…erUtils.openUrl(URL) method
MartinKanters
force-pushed
the
feature/make-git-plugin-extensible
branch
from
July 25, 2023 09:20
211d36d
to
6602913
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the git-plugin from Azure Devops and attempts to create a generic layer in order for being able to implement other Git providers like GitHub.
Summary:
provider.azure
.I've tested it successfully using both
mvn quarkus:dev
and injecting it as a plugin to ret. Only a snapshot build of the latest commit of ret worked, with the released 0.1.3 I get the following error (edit: this is not fixed with 0.1.4, but is probably due to me using an arm machine for building the plugin while RET is amd, when building ret myself, it works.):Also, I had to replace all
boolean
s withjava.lang.Boolean
in the .plugin file after initializing it. (edit: this one is fixed when using 0.1.4)I'll try to work on a GitHub implementation next (in a separate PR).
What do you think?