Ensure slave nodes use same host as CT #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/erlang/otp/blob/bc22321f10c1ad71fb7e28275a8e6ed26a34d4ab/lib/stdlib/src/slave.erl#L287-L309 The above code checks to see if the slave is running on the same host as the master, and if not, uses `rsh` to configure the slave. Since `rsh` is blocked on my machine, I got connection refused. So, I decided that we should use whatever the Common Test nodes hostname is, which will probably be `localhost`. By using the same hostname, we should remove the chance that `rsh` will be used.
|
Thanks @kjnilsson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/erlang/otp/blob/bc22321f10c1ad71fb7e28275a8e6ed26a34d4ab/lib/stdlib/src/slave.erl#L287-L309
The above code checks to see if the slave is running on the same host as the master, and if not, uses
rshto configure the slave. Sincershis blocked on my machine, I got connection refused.So, I decided that we should use whatever the Common Test nodes hostname is, which will probably be
localhost. By using the same hostname, we should remove the chance thatrshwill be used.