Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for #54 #103

Merged
merged 15 commits into from
May 31, 2020
Merged

possible fix for #54 #103

merged 15 commits into from
May 31, 2020

Conversation

aghaynes
Copy link
Contributor

this hopefully filters the last line of install_win.bat from the tinytex install which is stopping the install on windows at the moment (see #54)

I say hopefully as it is untested. A colleague helped with this, and feels that it could work though...

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff8d11...d447928. Read the comment docs.

@jimhester
Copy link
Member

I realize you have put a fair amount of work into this and I apologize for not looking at what you were doing earlier. However these actions are written in typescript, e.g. in https://github.com/r-lib/actions/blob/master/setup-tinytex/src/setup-tinytex.ts which is then compiled to javascript.

So rather than editing the javascript directly you need to edit the typescript source, then call npm run format && npm run build to generate the javascript files.

aghaynes and others added 2 commits May 18, 2020 08:13
did not commit changes to package*.json (related to version of prettier
used)
@aghaynes
Copy link
Contributor Author

thanks @jimhester I made the changes (hopefully correctly, as I say, I don't have much of a clue about js). I did not commit changes that my installation of npm made to the package*.yaml files, which related to different versions of prettify (or something similar)

@aghaynes
Copy link
Contributor Author

FWIW, I tested this on a build (by referencing my fork in the workflow file as opposed to the r-lib one), and it seems to work (no error on compiling the PDF vignette)... see https://github.com/aghaynes/secuTrialR-1/runs/684459045

@jimhester jimhester merged commit 31a8935 into r-lib:master May 31, 2020
@jimhester
Copy link
Member

Thanks again for working on this!

@aghaynes
Copy link
Contributor Author

aghaynes commented Jun 2, 2020

Thanks Jim! :)

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants