-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible fix for #54 #103
possible fix for #54 #103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 Continue to review full report at Codecov.
|
I realize you have put a fair amount of work into this and I apologize for not looking at what you were doing earlier. However these actions are written in typescript, e.g. in https://github.com/r-lib/actions/blob/master/setup-tinytex/src/setup-tinytex.ts which is then compiled to javascript. So rather than editing the javascript directly you need to edit the typescript source, then call |
did not commit changes to package*.json (related to version of prettier used)
thanks @jimhester I made the changes (hopefully correctly, as I say, I don't have much of a clue about js). I did not commit changes that my installation of npm made to the package*.yaml files, which related to different versions of prettify (or something similar) |
FWIW, I tested this on a build (by referencing my fork in the workflow file as opposed to the r-lib one), and it seems to work (no error on compiling the PDF vignette)... see https://github.com/aghaynes/secuTrialR-1/runs/684459045 |
Thanks again for working on this! |
Thanks Jim! :) |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
this hopefully filters the last line of install_win.bat from the tinytex install which is stopping the install on windows at the moment (see #54)
I say hopefully as it is untested. A colleague helped with this, and feels that it could work though...