Make number of dummy elements grow as needed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of being hard-coded to 16, the number of dummy elements will now be calculated based on the width of the page, and grow as necessary when the page is resized. Note that elements are not destroyed, since even a very large monitor won't have too many elements and creating/destroying elements on every resize may introduce a (very minor) performance concern. This way its still fast, since at most it'll only ever create ~6 elements on most monitors, but it can still handle infinitely large monitors.
|
I like the idea of adding elements as necessary but not bothering to delete them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of being hard-coded to 16, the number of dummy elements will now be calculated based on the width of the page, and grow as necessary when the page is resized.
Note that elements are not destroyed, since even a very large monitor won't have too many elements and creating/destroying elements on every resize may introduce a (very minor) performance concern. This way its still fast, since at most it'll only ever create ~6 elements on most monitors, but it can still handle infinitely large monitors.