Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): disable qwikVite linter to speed up preview and builds #936

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 18, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Eslint working in VSCode should be enough.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Aug 18, 2024

⚠️ No Changeset found

Latest commit: 5834623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 18, 2024

commit: 5834623

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@936
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@936
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@936
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@936

Open in Stackblitz

@maiieul maiieul merged commit 6ba4b36 into qwikifiers:main Aug 18, 2024
6 checks passed
thejackshelton added a commit that referenced this pull request Aug 19, 2024
* chore(website): bump to qwik 1.7.3 + entry files output (#926)

* Revert-new-sw (#927)

* Revert "change to new sw impl"

This reverts commit 3081504.

* chore(website): charSet -> charset in root.tsx

* Remove-import-meta-glob-eager-true (#928)

* chore(website): remove import.meta.glob eager true

* chore(website): comment out vite config trick to se chunk names

* chore(pkg.pr.new): remove 0.0.9 flag (#921)

* chore(qwik-themes): move code internally + signal implementation (#922)

* chore(qwik-themes): move code internally under _state folder

* chore(themes): linting

* fix(themes): use signals instead of stores

* chore(themes provider): useVisibleTask to useOnWindow

* chore(themes): move to qwik-ui/themes

* Tooltip Beta (#934)

* feat(tooltip): implement tooltip to beta phase

* fix(tooltip): small tweaks to the tooltip state

* fix: remove animations form tooltip docs and fix placement example

* feat(tooltip): implement onOpenChange$

* chore: fix changeset type

* test: update placement test to remove loop

* fix: remove breaking examples and tooltip route

* fix: checkbox tests preventing us from opening pw

* refactor: deprecate popover hover prop in favor of tooltip

* latest

---------

Co-authored-by: Christopher Woolum <[email protected]>

* fix: comment out bundle issue when changing user pref (#935)

* chore(website): disable qwikVite linter to speed up preview and builds (#936)

* Inline comp docs (#931)

* allow people to pass handlers to modal close

* docs: improve contributor guide

* docs: mention inline components

* add utils changeset (#937)

* Version Packages (#917)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(/themes): turn visible task to strategy:document-idle (#938)

* chore(/themes): turn visible task to strategy:document-idle

* fix(themes): add timeout to themeSig assignment to localstorage

* fix(themes): augment timeout to themeSig assignment to localstorage

* fix(website): remove js execution on load by assigning themes sig on click (#939)

* feat: static adapter

* use improved shiki node version now that we're on static

---------

Co-authored-by: Maïeul <[email protected]>
Co-authored-by: Christopher Woolum <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: maiieul <[email protected]>
maiieul added a commit that referenced this pull request Aug 21, 2024
* allow people to pass handlers to modal close

* moving to the static adapter

* Preview (#940)

* chore(website): bump to qwik 1.7.3 + entry files output (#926)

* Revert-new-sw (#927)

* Revert "change to new sw impl"

This reverts commit 3081504.

* chore(website): charSet -> charset in root.tsx

* Remove-import-meta-glob-eager-true (#928)

* chore(website): remove import.meta.glob eager true

* chore(website): comment out vite config trick to se chunk names

* chore(pkg.pr.new): remove 0.0.9 flag (#921)

* chore(qwik-themes): move code internally + signal implementation (#922)

* chore(qwik-themes): move code internally under _state folder

* chore(themes): linting

* fix(themes): use signals instead of stores

* chore(themes provider): useVisibleTask to useOnWindow

* chore(themes): move to qwik-ui/themes

* Tooltip Beta (#934)

* feat(tooltip): implement tooltip to beta phase

* fix(tooltip): small tweaks to the tooltip state

* fix: remove animations form tooltip docs and fix placement example

* feat(tooltip): implement onOpenChange$

* chore: fix changeset type

* test: update placement test to remove loop

* fix: remove breaking examples and tooltip route

* fix: checkbox tests preventing us from opening pw

* refactor: deprecate popover hover prop in favor of tooltip

* latest

---------

Co-authored-by: Christopher Woolum <[email protected]>

* fix: comment out bundle issue when changing user pref (#935)

* chore(website): disable qwikVite linter to speed up preview and builds (#936)

* Inline comp docs (#931)

* allow people to pass handlers to modal close

* docs: improve contributor guide

* docs: mention inline components

* add utils changeset (#937)

* Version Packages (#917)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(/themes): turn visible task to strategy:document-idle (#938)

* chore(/themes): turn visible task to strategy:document-idle

* fix(themes): add timeout to themeSig assignment to localstorage

* fix(themes): augment timeout to themeSig assignment to localstorage

* fix(website): remove js execution on load by assigning themes sig on click (#939)

* feat: static adapter

* use improved shiki node version now that we're on static

---------

Co-authored-by: Maïeul <[email protected]>
Co-authored-by: Christopher Woolum <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: maiieul <[email protected]>

* fix(website): click on copy code

---------

Co-authored-by: jack shelton <[email protected]>
Co-authored-by: Jack Shelton <[email protected]>
Co-authored-by: Christopher Woolum <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant