Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single shiki instance & on the server w/ dev #906

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

thejackshelton
Copy link
Collaborator

@thejackshelton thejackshelton commented Jul 26, 2024

What is it?

Preview route transitions are now much faster, shiki should now be working correctly in dev mode and preview, as I believe the previous error was due to multiple instances being created each time an example was rendered.

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 8d5eed4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 26, 2024

commit: 8d5eed4

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@906
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@906
npm i https://pkg.pr.new/qwikifiers/qwik-ui@906
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@906

Open in Stackblitz

Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool find! I didn't think of creating the highlighter and then awaiting it in the component 🙈

Just re-added the track(() => code) as it is required for the MakeItYours's CopyCSSConfig. There's still a flicker. Maybe we can fix it with a computed sig, but for another PR!

@maiieul maiieul merged commit f5c831b into qwikifiers:main Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants