Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting looks incorrect for vertical axis #2

Closed
hybridherbst opened this issue Oct 9, 2023 · 6 comments
Closed

Sorting looks incorrect for vertical axis #2

hybridherbst opened this issue Oct 9, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@hybridherbst
Copy link
Contributor

Seems while sorting is fine in the horizontal axis, it's incorrect in the vertical axis:
https://github.com/quadjr/aframe-gaussian-splatting/assets/2693840/d0330b01-9728-49dc-938b-5955be10b29e
(same with the train scene)

@quadjr quadjr self-assigned this Oct 9, 2023
@quadjr quadjr added the bug Something isn't working label Oct 9, 2023
@quadjr
Copy link
Owner

quadjr commented Oct 9, 2023

Thank you for your report. It looks strange.
Could you share the HTML code?

@hybridherbst
Copy link
Contributor Author

Haven't changed anything so far!

@hybridherbst
Copy link
Contributor Author

I think the only difference is that in your sample I can't rotate the camera so that it looks from above.

To repro, you can set position="0 -1.5 0" and use my .ply file;
then rotate around the scene:

Screen.Recording.2023-10-09.at.09.32.05.mov

@quadjr
Copy link
Owner

quadjr commented Oct 9, 2023

Thanks. I've reproduced the issue. I'll fix it later. The coordinates for AFrame and Gaussian Splatting are different, which is a bit confusing.

quadjr added a commit that referenced this issue Oct 9, 2023
@quadjr
Copy link
Owner

quadjr commented Oct 9, 2023

I've fixed it!
30985bf

@quadjr quadjr closed this as completed Oct 9, 2023
@hybridherbst
Copy link
Contributor Author

Wonderful! Thank you :)

hybridherbst added a commit to needle-tools/needle-engine-samples that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants