Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Kinesis + Pro Micro #9944

Merged
merged 10 commits into from
Aug 17, 2020
Merged

[Keyboard] Kinesis + Pro Micro #9944

merged 10 commits into from
Aug 17, 2020

Conversation

nguyenvietyen
Copy link
Contributor

@nguyenvietyen nguyenvietyen commented Aug 5, 2020 •
edited
Loading

This is my first work ever with QMK - I'm not intimate yet with all details and considerations.

This PR comprises two parts:

  • mod to retrofit the Kinesis Advantage keyboard with a Arduine Pro Micro (clone).
  • a Dvorak keymap that is based on the Kinesis default. The ESC and Caps lock keys are swapped.

I'd appreciate feedback, particularly on:

  • how to implement a faster debounce strategy for reducing lag DONE.
  • whether setting the pinouts is necessary too in nguyenvietyen.c
  • general code conventions and potential cleanups

Thank you!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nguyenvietyen nguyenvietyen reopened this Aug 7, 2020
drashna
drashna reviewed Aug 7, 2020
View reviewed changes
keyboards/kinesis/config.h Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/dvorak_nguyenvietyen/config.h Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/dvorak_nguyenvietyen/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested review from zvecr and a team August 7, 2020 08:24
noroadsleft
noroadsleft requested changes Aug 7, 2020
View reviewed changes
keyboards/kinesis/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/README.md Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/README.md Outdated Show resolved Hide resolved
@nguyenvietyen
Copy link
Contributor Author

Thank you all for the constructive feedback!

I'll do the cleanups and prepare this PR for merging.

@nguyenvietyen nguyenvietyen marked this pull request as ready for review August 8, 2020 06:38
@nguyenvietyen
Copy link
Contributor Author

Cleanups are done. This PR should be ready for merging, unless further feedback arises.

@nguyenvietyen
[Keyboard] Kinesis + Pro Micro init
e88246e 
- docs for DIY
- custom matrix = lite
- a near-factory dvorak mapping
- optimized debouncing for lower latency
fauxpark
fauxpark requested changes Aug 8, 2020
View reviewed changes
keyboards/kinesis/nguyenvietyen/config.h Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/dvorak_nguyenvietyen/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/matrix.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 8, 2020
View reviewed changes
keyboards/kinesis/nguyenvietyen/matrix.c Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/matrix.c Outdated Show resolved Hide resolved
keyboards/kinesis/nguyenvietyen/matrix.c Outdated Show resolved Hide resolved
@nguyenvietyen
chore: PR feedback
355cc47 
Signed-off-by: Viet Yen Nguyen <[email protected]>
@nguyenvietyen
fix: compile error
5d08424 
Signed-off-by: Viet Yen Nguyen <[email protected]>
@fauxpark fauxpark requested a review from a team August 8, 2020 13:19
@nguyenvietyen
Copy link
Contributor Author

I just discovered a minor led activation bug when hooked to my docking station while the laptop is disconnected.

Please hold off merging until I push the fix.

@nguyenvietyen
Copy link
Contributor Author

I just discovered a minor led activation bug when hooked to my docking station while the laptop is disconnected.

Please hold off merging until I push the fix.

I've investigated it a bit. The Docking station is practically a USB hub. When the laptop gets disconnected, it looks like QMK is sending 0 to all led outputs. Due to the Kinesis wiring, all keyboard LEDs are switched on by that.

I'll look further for a solution.

So this doesn't block merging, but it would be nice to address it as part of this PR.

@nguyenvietyen
Copy link
Contributor Author

I just discovered a minor led activation bug when hooked to my docking station while the laptop is disconnected.
Please hold off merging until I push the fix.

I've investigated it a bit. The Docking station is practically a USB hub. When the laptop gets disconnected, it looks like QMK is sending 0 to all led outputs. Due to the Kinesis wiring, all keyboard LEDs are switched on by that.

I'll look further for a solution.

So this doesn't block merging, but it would be nice to address it as part of this PR.

I've just fixed the LED activation bug.

The PR is ready again for review (and merging).

@fauxpark fauxpark requested a review from a team August 9, 2020 21:46
@noroadsleft noroadsleft merged commit 194dc09 into qmk:master Aug 17, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@nguyenvietyen @nicocesar
[Keyboard] Kinesis + Pro Micro (qmk#9944)
3f80b82 
* [Keyboard] Kinesis + Pro Micro init

- docs for DIY
- custom matrix = lite
- a near-factory dvorak mapping
- optimized debouncing for lower latency

* chore: reformatting

* chore: update doc

* chore: cleanups according to PR feedback

* chore: PR feedback

* fix: compile error

* chore: add include

* fix: LEDs hanging after USB disconnect

* chore: enable QMK goodies by default

* chore: use semantic write pin
@asmodeus812 asmodeus812 mentioned this pull request Feb 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nguyenvietyen @noroadsleft @drashna @fauxpark