Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always notify user about duplicate torrent #21480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 3, 2024

Closes #21475.

@glassez glassez added the GUI GUI-related issues/changes label Oct 3, 2024
@glassez glassez added this to the 5.0.1 milestone Oct 3, 2024
@xavier2k6
Copy link
Member

I don't use private torrents, so will leave this to @thalieht or others to verify.

@glassez
Copy link
Member Author

glassez commented Oct 3, 2024

I don't use private torrents, so will leave this to @thalieht or others to verify.

It's not just about private torrents. Just disable merge trackers confirmation dialog (it is just force disabled for private torrents).

@xavier2k6
Copy link
Member

I don't use private torrents, so will leave this to @thalieht or others to verify.

It's not just about private torrents. Just disable merge trackers confirmation dialog (it is just force disabled for private torrents).

Ok, will test.

@xavier2k6
Copy link
Member

Tested!

Options - off
Screenshot 2024-10-03 115226

Presented with this
Screenshot 2024-10-03 115148

@xavier2k6
Copy link
Member

While testing these options, I noticed that when Merge trackers to existing torrent is selected, the user is presented with below dialog:

Screenshot 2024-10-03 115639


I think Trackers is merged from new source doesn't quite read/sound right.....
Should be more like Tracker(s) merged from new source

@glassez
Copy link
Member Author

glassez commented Oct 3, 2024

I think Trackers is merged from new source doesn't quite read/sound right.....
Should be more like Tracker(s) merged from new source

Changed.

@stalkerok
Copy link
Contributor

What if I add many torrents at a time and don't want to see any dialog boxes of possible repeats? This is not a 5.0 feature and it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.0.0 No warning message displayed when trying to add duplicated torrent
4 participants