Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Fix CIs #567

Merged
merged 2 commits into from
Apr 30, 2024
Merged

MAINT: Fix CIs #567

merged 2 commits into from
Apr 30, 2024

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Apr 30, 2024 •
edited
Loading

Closes #528

@larsoner
Copy link
Contributor Author

At this point I'm not sure actually what Azure adds to our testing. I'm inclined to remove it entirely and just stick with GHA. Okay @tkoyama010 ?

@larsoner larsoner enabled auto-merge (squash) April 30, 2024 15:34
@tkoyama010
Copy link
Member

At this point I'm not sure actually what Azure adds to our testing. I'm inclined to remove it entirely and just stick with GHA. Okay @tkoyama010 ?

Thanks! That is a forget to delete.

tkoyama010
tkoyama010 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larsoner larsoner merged commit 4ae5363 into pyvista:main Apr 30, 2024
29 checks passed
@larsoner larsoner deleted the cis branch April 30, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsoner @tkoyama010