Fix overrestimating if no optimizer class is found. #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40064919 |
Summary: Pull Request resolved: pytorch#685 As titled. Planner estimated storage needed to be double the size of parameters when optimizer class is not provided. When opt class is not given, we want to estimate storage needed to be the size of parameters. Reviewed By: YLGH Differential Revision: D40064919 fbshipit-source-id: 1afb6fe5956fc2f1d12cc7ad780124d2e7d2e20b
lequytra
force-pushed
the
export-D40064919
branch
from
18a4d71
to
1d31606
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40064919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Planner estimated storage needed to be double the size of parameters when optimizer class is not provided. When opt class is not given, we want to estimate storage needed to be the size of parameters.
Differential Revision: D40064919