Add INT8 support to torchrec qcomm codecs #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 19, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: c91b40da5b87a001ad754346aa43df96c7252e65
yusuo
force-pushed
the
export-D39473544
branch
from
71eed9c
to
c2ba402
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
jianyuh
pushed a commit
to jianyuh/torchrec-3
that referenced
this pull request
Sep 24, 2022
Summary: We want to make the EB/EBC scriptable by default w/o the need of running torch.fx first. Not able to script EB/EBC modules by default (especially when needed for inference) is very non-intuitive and inconvenient. In the same time we don't plan to make ShardedEB/EBC scriptable. 1. Do not use property, use methods instead. This is consistent w/ KJT. 1. _embedding_bag_configs has a complex type List[EmbeddingBagConfig] which does not script. Use List[str] to store features instead. X-link: facebookresearch/ReAgent#648 Pull Request resolved: pytorch#467 Reviewed By: colin2328 Differential Revision: D37389962 fbshipit-source-id: 5ce079a946b9458ee63658cae2fd731cfc1c7958
yusuo
force-pushed
the
export-D39473544
branch
from
c2ba402
to
d7d9131
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: f787eaaf86dacbfff690379d8ca8c0d28a7505b0
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: cf14cf907324a06444d606cce40d9c3ef045ee24
yusuo
force-pushed
the
export-D39473544
branch
from
d7d9131
to
e8db428
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: 469b5486d30babd2b63ee12378eff79f2aa463a1
yusuo
force-pushed
the
export-D39473544
branch
from
e8db428
to
a9191b1
Compare
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 27, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: e4d8bfe53a13f0d1ff6a4ee755ad9bee73d9e587
yusuo
force-pushed
the
export-D39473544
branch
from
a9191b1
to
098ef95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 29, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: 6d786722416e817d0c6a7ed822e65f43247be972
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
yusuo
force-pushed
the
export-D39473544
branch
from
098ef95
to
f9a4c02
Compare
yusuo
added a commit
to yusuo/torchrec
that referenced
this pull request
Sep 29, 2022
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Differential Revision: D39473544 fbshipit-source-id: adeeb4d443d3deb89c317c8f17fab6b763b9bb43
yusuo
force-pushed
the
export-D39473544
branch
from
f9a4c02
to
bcab049
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
Summary: Pull Request resolved: pytorch#648 Added INT8 support to torchrec comm library based on the changes in D39473386 Reviewed By: YLGH Differential Revision: D39473544 fbshipit-source-id: e26f9f01d8b6d0110abd28c5f47f627f9f526118
yusuo
force-pushed
the
export-D39473544
branch
from
bcab049
to
3267b57
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39473544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Added INT8 support to torchrec comm library based on the changes in D39473386
Differential Revision: D39473544