Add reverse module for ComputeKJTToJTDict to combine jt_dict to kjt #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49423522 |
wpc
added a commit
to wpc/torchrec
that referenced
this pull request
Sep 19, 2023
…ytorch#1399) Summary: so that we don't need fx wrap KeyedJaggedTensor.from_jt_dict(jt_dict) manually everywhere. Also base on this we can do graph patten matching cancel (ComputeKJTToJTDict, ComputeKJTToJTDict) pairs during publish to save compute cycles. (see next diff in the stack) Reviewed By: YazhiGao Differential Revision: D49423522 Privacy Context Container: 314155190942957
wpc
force-pushed
the
export-D49423522
branch
from
7a23722
to
224e4aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49423522 |
…ytorch#1399) Summary: so that we don't need fx wrap KeyedJaggedTensor.from_jt_dict(jt_dict) manually everywhere. Also base on this we can do graph patten matching cancel (ComputeKJTToJTDict, ComputeKJTToJTDict) pairs during publish to save compute cycles. (see next diff in the stack) Reviewed By: houseroad, YazhiGao Differential Revision: D49423522 Privacy Context Container: 314155190942957
wpc
force-pushed
the
export-D49423522
branch
from
224e4aa
to
1d44fad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49423522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: so that we don't need fx wrap KeyedJaggedTensor.from_jt_dict(jt_dict) manually everywhere. Also base on this we can do graph patten matching cancel (ComputeKJTToJTDict, ComputeKJTToJTDict) pairs during publish to save compute cycles. (see next diff in the stack)
Differential Revision:
D49423522
Privacy Context Container: 314155190942957