Trying to fix the hotloading incompatibility issue #1380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48912014 |
levythu
pushed a commit
to levythu/torchrec
that referenced
this pull request
Sep 5, 2023
…h#1380) Summary: Having discussion with jgk, we believe this is the right fix: check this out https://fburl.com/code/v60tnefc here we require https://fburl.com/code/gf6v4asr torchrec https://fburl.com/code/jn8eoyxs is not part of "//torchrec/distributed:distributed" distributed uses model_parallel model_parallel uses sharding_plan sharding_plan includes fp_embeddingbag BUT it does not include mc_embeddingbag so the better solve instead of D48973797 would be to add mc_embeddingbag in https://fburl.com/code/td7f2682 then this dependency will roll up into mc_embeddingbag -> sharding_plan -> model_parallel -> distributed -> https://fburl.com/code/zjxooggp -> https://fburl.com/code/xgpq1y3m Differential Revision: D48912014
levythu
force-pushed
the
export-D48912014
branch
from
b43ad3e
to
f8ba622
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48912014 |
levythu
pushed a commit
to levythu/torchrec
that referenced
this pull request
Sep 6, 2023
…h#1380) Summary: Having discussion with jgk, we believe this is the right fix: check this out https://fburl.com/code/v60tnefc here we require https://fburl.com/code/gf6v4asr torchrec https://fburl.com/code/jn8eoyxs is not part of "//torchrec/distributed:distributed" distributed uses model_parallel model_parallel uses sharding_plan sharding_plan includes fp_embeddingbag BUT it does not include mc_embeddingbag so the better solve instead of D48973797 would be to add mc_embeddingbag in https://fburl.com/code/td7f2682 then this dependency will roll up into mc_embeddingbag -> sharding_plan -> model_parallel -> distributed -> https://fburl.com/code/zjxooggp -> https://fburl.com/code/xgpq1y3m Differential Revision: D48912014
levythu
force-pushed
the
export-D48912014
branch
from
f8ba622
to
71990d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48912014 |
…h#1380) Summary: Having discussion with jgk, we believe this is the right fix: check this out https://fburl.com/code/v60tnefc here we require https://fburl.com/code/gf6v4asr torchrec https://fburl.com/code/jn8eoyxs is not part of "//torchrec/distributed:distributed" distributed uses model_parallel model_parallel uses sharding_plan sharding_plan includes fp_embeddingbag BUT it does not include mc_embeddingbag so the better solve instead of D48973797 would be to add mc_embeddingbag in https://fburl.com/code/td7f2682 then this dependency will roll up into mc_embeddingbag -> sharding_plan -> model_parallel -> distributed -> https://fburl.com/code/zjxooggp -> https://fburl.com/code/xgpq1y3m Reviewed By: dstaay-fb Differential Revision: D48912014
levythu
force-pushed
the
export-D48912014
branch
from
71990d8
to
1c38f4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48912014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Having discussion with jgk, we believe this is the right fix:
check this out https://fburl.com/code/v60tnefc
here we require https://fburl.com/code/gf6v4asr
torchrec
https://fburl.com/code/jn8eoyxs is not part of "//torchrec/distributed:distributed"
distributed uses model_parallel
model_parallel uses sharding_plan
sharding_plan includes fp_embeddingbag
BUT it does not include mc_embeddingbag
so the better solve instead of D48973797 would be to add mc_embeddingbag in https://fburl.com/code/td7f2682
then this dependency will roll up into
mc_embeddingbag -> sharding_plan -> model_parallel -> distributed -> https://fburl.com/code/zjxooggp -> https://fburl.com/code/xgpq1y3m
Differential Revision: D48912014